Fix test failures from removed image references by Copilot · Pull Request #44932 · trueforge-org/truecharts

Copilot · 2026-02-14T14:15:27Z

Tests were failing because wgetImage and other deprecated images were removed from values.yaml but their references remained in templates and schemas.

Changes:

Replace wgetImage → ubuntuImage in clickhouse/solr wait containers (_dbWait.tpl)
Remove orphaned schema files: wgetImage, alpineImage, scratchImage, yqImage, openvpnImage, wireguardImage, redisClientImage
Clean schema references in values.schema.json

Before:

{{- define "tc.v1.common.lib.deps.wait.clickhouse" -}}
imageSelector: wgetImage  # Image no longer exists

After:

{{- define "tc.v1.common.lib.deps.wait.clickhouse" -}}
imageSelector: ubuntuImage  # Uses existing ubuntu image with wget

All 1346 unit tests now pass.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

… image schemas Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>

Copilot

Pull request overview

Fixes unit test failures caused by stale/removed image selectors and schema references after deprecated images were removed from values.yaml.

Changes:

Switch ClickHouse/Solr wait containers from wgetImage to ubuntuImage in _dbWait.tpl.
Remove schema references for deprecated/orphaned image selectors from values.schema.json.
Delete orphaned per-image schema files for removed image selectors.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
charts/library/common/values.schema.json	Removes properties/$refs for deleted image schemas so schema validation matches current values/templates.
charts/library/common/templates/lib/dependencies/_dbWait.tpl	Updates wait container `imageSelector` to an existing image key to avoid missing-image references.
charts/library/common/schemas/images/yqImage.json	Deletes orphaned image schema file.
charts/library/common/schemas/images/wireguardImage.json	Deletes orphaned image schema file.
charts/library/common/schemas/images/wgetImage.json	Deletes orphaned image schema file.
charts/library/common/schemas/images/scratchImage.json	Deletes orphaned image schema file.
charts/library/common/schemas/images/redisClientImage.json	Deletes orphaned image schema file.
charts/library/common/schemas/images/openvpnImage.json	Deletes orphaned image schema file.
charts/library/common/schemas/images/alpineImage.json	Deletes orphaned image schema file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-14T14:29:08Z

charts/library/common/values.schema.json

      "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/codeserverImage.json",
      "description": "Configuration for `codeserverImage`."
    },
-    "alpineImage": {
-      "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/alpineImage.json",
-      "description": "Configuration for `alpineImage`."
-    },
    "ubuntuImage": {
      "$ref": "file:///home/runner/work/truecharts/truecharts/charts/library/common/schemas/images/ubuntuImage.json",
      "description": "Configuration for `ubuntuImage`."


These $ref values use an absolute CI-runner filesystem path (file:///home/runner/...), which makes schema validation non-portable outside that exact environment. Prefer repository-relative refs (or a consistent project-root relative URI) so editors/validators and local tooling can resolve schemas reliably.

Copilot · 2026-02-14T14:29:08Z

charts/library/common/templates/lib/dependencies/_dbWait.tpl

 {{- define "tc.v1.common.lib.deps.wait.clickhouse" -}}
 enabled: true
 type: system
-imageSelector: wgetImage
+imageSelector: ubuntuImage
 securityContext:
  runAsUser: 568
  runAsGroup: 568


These wait containers previously used a dedicated wgetImage selector; switching to ubuntuImage can couple the wait logic to whatever tooling happens to be present in the Ubuntu image. To avoid future drift (e.g., if the base image changes), consider documenting the required binaries for these wait containers (wget/curl/nc/etc.) or using an image selector whose name/contract explicitly guarantees those tools.

Copilot · 2026-02-14T14:29:08Z

charts/library/common/templates/lib/dependencies/_dbWait.tpl

 enabled: true
 type: system
-imageSelector: wgetImage
+imageSelector: ubuntuImage


These wait containers previously used a dedicated wgetImage selector; switching to ubuntuImage can couple the wait logic to whatever tooling happens to be present in the Ubuntu image. To avoid future drift (e.g., if the base image changes), consider documenting the required binaries for these wait containers (wget/curl/nc/etc.) or using an image selector whose name/contract explicitly guarantees those tools.

Suggested change

imageSelector: ubuntuImage

imageSelector: wgetImage

Tests were failing because `wgetImage` and other deprecated images were removed from `values.yaml` but their references remained in templates and schemas. **Changes:** - Replace `wgetImage` → `ubuntuImage` in clickhouse/solr wait containers (`_dbWait.tpl`) - Remove orphaned schema files: `wgetImage`, `alpineImage`, `scratchImage`, `yqImage`, `openvpnImage`, `wireguardImage`, `redisClientImage` - Clean schema references in `values.schema.json` **Before:** ```yaml {{- define "tc.v1.common.lib.deps.wait.clickhouse" -}} imageSelector: wgetImage # Image no longer exists ``` **After:** ```yaml {{- define "tc.v1.common.lib.deps.wait.clickhouse" -}} imageSelector: ubuntuImage # Uses existing ubuntu image with wget ``` All 1346 unit tests now pass.  --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>

truecharts-admin · 2026-02-22T00:18:19Z

This PR is locked to prevent necro-posting on closed PRs. Please create a issue or contact staff on discord if you want to further discuss this

Initial plan

b7d6977

Copilot AI assigned Copilot and Crow-Control Feb 14, 2026

Copilot AI mentioned this pull request Feb 14, 2026

major(common): BREAKING CHANGE Common 2026 #41017

Draft

13 tasks

Copilot started work on behalf of Crow-Control February 14, 2026 14:16 View session

Fix tests by replacing wgetImage with ubuntuImage and removing unused…

08debbd

… image schemas Co-authored-by: PrivatePuffin <7613738+PrivatePuffin@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Remove env-list support and unused containers~~ Fix test failures from removed image references Feb 14, 2026

Copilot AI requested a review from Crow-Control February 14, 2026 14:23

Copilot finished work on behalf of Crow-Control February 14, 2026 14:23

Crow-Control marked this pull request as ready for review February 14, 2026 14:23

Copilot AI review requested due to automatic review settings February 14, 2026 14:23

Crow-Control requested review from Boemeltrein, StevenMcElligott, alfi0812, stavros-k and xstar97 as code owners February 14, 2026 14:23

Crow-Control merged commit e362718 into common2026 Feb 14, 2026
2 checks passed

Crow-Control deleted the copilot/sub-pr-41017 branch February 14, 2026 14:23

Copilot AI reviewed Feb 14, 2026

View reviewed changes

Copilot started reviewing on behalf of Crow-Control February 14, 2026 14:32 View session

trueforge-org locked as resolved and limited conversation to collaborators Feb 22, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix test failures from removed image references#44932

Fix test failures from removed image references#44932
Crow-Control merged 2 commits intocommon2026from
copilot/sub-pr-41017

Copilot AI commented Feb 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

Copilot AI Feb 14, 2026

Uh oh!

truecharts-admin commented Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

Uh oh!

truecharts-admin commented Feb 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Feb 14, 2026 •

edited

Loading